<html>
<head><meta charset="utf-8"><title>issues with merged PRs · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html">issues with merged PRs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="199661793"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199661793" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199661793">(Jun 03 2020 at 19:02)</a>:</h4>
<p>When a PR is merged to fix an issue, should I signal that the issue can be closed ?</p>



<a name="199661849"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199661849" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199661849">(Jun 03 2020 at 19:02)</a>:</h4>
<p>If yes, who should I ping (especially on old issues where the author might not respond anymore) ?</p>



<a name="199661884"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199661884" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199661884">(Jun 03 2020 at 19:03)</a>:</h4>
<p>You can add <code>fixes #70107</code> or <code>closes #70107</code> to your PR to automatically close the relevant issue.</p>



<a name="199661940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199661940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199661940">(Jun 03 2020 at 19:03)</a>:</h4>
<p>Oh, today I learned, thanks a lot !</p>



<a name="199661944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199661944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199661944">(Jun 03 2020 at 19:03)</a>:</h4>
<p>If the PR is already merged, I think the best way is to add a comment on the issue mentioning that it should now be fixed</p>



<a name="199662025"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199662025" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199662025">(Jun 03 2020 at 19:04)</a>:</h4>
<p>and in case the author or a team member does not close it in the next few days you can ask on zulip or the PR itself I guess <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="199662117"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199662117" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199662117">(Jun 03 2020 at 19:05)</a>:</h4>
<p>Will do ! I have to say contributing to Rust way less scary than I expected with all the people answering questions</p>



<a name="199662153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199662153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199662153">(Jun 03 2020 at 19:05)</a>:</h4>
<p>That's the goal <span aria-label="sparkles" class="emoji emoji-2728" role="img" title="sparkles">:sparkles:</span></p>



<a name="199683778"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199683778" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199683778">(Jun 03 2020 at 22:14)</a>:</h4>
<p><span class="user-mention silent" data-user-id="216206">lcnr</span> <a href="#narrow/stream/122651-general/topic/issues.20with.20merged.20PRs/near/199661884">said</a>:</p>
<blockquote>
<p>You can add <code>fixes #70107</code> or <code>closes #70107</code> to your PR to automatically close the relevant issue.</p>
</blockquote>
<p>When is the issue closed in this case: when I open the PR, during the PR, after the PR is successfully merged ?</p>
<p>Also, do titles like <code>Short Description. fixes #1234</code> work ?</p>



<a name="199684045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199684045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mark Drobnak <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199684045">(Jun 03 2020 at 22:17)</a>:</h4>
<p><a href="https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue">https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue</a></p>



<a name="199684064"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199684064" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mark Drobnak <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199684064">(Jun 03 2020 at 22:17)</a>:</h4>
<p>Looks like it needs to be in the description</p>



<a name="199684633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199684633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199684633">(Jun 03 2020 at 22:23)</a>:</h4>
<blockquote>
<p>You can also use closing keywords in a commit message. The issue will be closed when you merge the commit into the default branch, but the pull request that contains the commit will not be listed as a linked pull request.</p>
</blockquote>
<p>This is in the github doc. As I understand it, it means that PRs should have one of their commit contains <code>Fix #1234</code> (or similar) ?</p>



<a name="199685140"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199685140" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199685140">(Jun 03 2020 at 22:28)</a>:</h4>
<p>An example might be <a href="https://github.com/rust-lang/rust/pull/72061">https://github.com/rust-lang/rust/pull/72061</a>. This PR contains <code>closes #70180</code> in its description.</p>
<p>I prefer mentioning the relevant issue in the description of the PR instead of a commit.</p>



<a name="199692150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/issues%20with%20merged%20PRs/near/199692150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/issues.20with.20merged.20PRs.html#199692150">(Jun 04 2020 at 00:01)</a>:</h4>
<p>Thank you for the example !</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>